Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup pod print in kubelet package #19145

Merged
merged 1 commit into from
Dec 29, 2015
Merged

Cleanup pod print in kubelet package #19145

merged 1 commit into from
Dec 29, 2015

Conversation

Random-Liu
Copy link
Member

Small cleanup in docker manager.

@Random-Liu Random-Liu added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Dec 28, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 28, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 28, 2015

GCE e2e test build/test passed for commit d22aa40fc063ef75a9474339959218bcb3c2d748.

@yifan-gu
Copy link
Contributor

@Random-Liu Are we planning to retire GetPodFullname entirely? I found there are other places that still use it.

@Random-Liu
Copy link
Member Author

@yifan-gu Good question...My understanding is that @yujuhong wants to use format.Pod instead of PodFullName only when printing pod, so that we can change the printing format of pod easily in the future.

@yifan-gu
Copy link
Contributor

@Random-Liu sgtm, then how about also cleaning up the prints in prober.go runonce.go as well in this PR to make it more consistent? (Maybe there are other places)

@Random-Liu
Copy link
Member Author

Sure~ Thanks! :)

@Random-Liu
Copy link
Member Author

@yifan-gu Also cleanup prober.go and runonce.go. I grep in all the files in kubelet, and can only find these two files which need to be cleaned up. Hope there are no other places. PTAL, :)

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 28, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 28, 2015

GCE e2e build/test failed for commit 7084a2291c2289c2cbff9e501cdc34ab6f676f67.

@yifan-gu
Copy link
Contributor

LGTM

@yifan-gu
Copy link
Contributor

Sorry, do you mind squashing the two commits? As they are really small and related.

@Random-Liu
Copy link
Member Author

Sure!

@Random-Liu
Copy link
Member Author

Squashed, :)

@yifan-gu
Copy link
Contributor

@Random-Liu Thank you, LGTM

@yifan-gu yifan-gu added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-merge labels Dec 28, 2015
@Random-Liu
Copy link
Member Author

Sorry, there is an extra import.

@k8s-bot
Copy link

k8s-bot commented Dec 28, 2015

GCE e2e build/test failed for commit 63832c11fb2e0fa673a4ebf752182ed410128bda.

@yifan-gu yifan-gu added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 28, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 28, 2015

GCE e2e build/test failed for commit 6e92ddf.

@Random-Liu
Copy link
Member Author

@k8s-bot e2e test this please.

@k8s-bot
Copy link

k8s-bot commented Dec 28, 2015

GCE e2e test build/test passed for commit 6e92ddf.

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Dec 29, 2015

GCE e2e test build/test passed for commit 6e92ddf.

@Random-Liu
Copy link
Member Author

@k8s-bot unit test this please.

@yifan-gu yifan-gu changed the title Cleanup pod print in dockertools/manager.go Cleanup pod print in kubelet package Dec 29, 2015
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Dec 29, 2015

GCE e2e test build/test passed for commit 6e92ddf.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Dec 29, 2015
Merge pull request #19145 from Random-Liu/cleanup-pod-print
03b3b61 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit 03b3b61 into kubernetes:master Dec 29, 2015
@Random-Liu Random-Liu deleted the cleanup-pod-print branch December 29, 2015 02:04
@yujuhong
Copy link
Contributor

yujuhong commented Jan 4, 2016

Thanks for the cleanup and the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yifan-gu yifan-gu

Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Random-Liu @k8s-github-robot @k8s-bot @yifan-gu @yujuhong @k8s-teamcity-mesosphere @googlebot